Geo Node Form Regression - Relative URLs broken
What does this MR do?
Closes #337177 (closed)
A bug was identified with more complex paths used in GitLab that the Nodes forms were redirecting to absolute paths which ended up with the user hitting a 404.
Ex. Domain: https://gitlab.example.com/gitlab/
removed the gitlab
parameter when redirecting resulting in the new path being https://gitlab.example.com/admin/geo/nodes
rather than https://gitlab.example.com/gitlab/admin/geo/nodes
This approach to fixing this was to revert to using the Rails Path variable for the geo_nodes page. This was how the redirects were handled before the forms was converted to Vue.
Screenshots or Screencasts (strongly suggested)
Bug | Fix |
---|---|
Bug | Fix |
How to setup and validate locally (strongly suggested)
- Set up Geo on your GDK
- Fetch/Checkout this branch on your Primary Node (gdk-primary)
- Update your Primary Node's (gdk-primary)
gdk.yml
by addingrelative_url_root: "/gitlab"
- Run
gdk reconfigure
For Geo Nodes Edit Form
- Navigate to
http://127:0:0:1/gitlab/admin/geo/nodes
- Click Edit
- Click Save changes or Cancel
- Ensure you are redirected back to
http://127:0:0:1/gitlab/admin/geo/nodes
and not 404
For Geo Nodes Settings Form
- Navigate to
http://127:0:0:1/gitlab/admin/geo/settings
- Click Cancel
- Ensure you are redirected back to
http://127:0:0:1/gitlab/admin/geo/nodes
and not 404
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Related to #337177 (closed)