Skip to content

Remove duplicate finding link creation

What does this MR do?

This MR prevents the StoreReportService from creating duplicate finding links as part of the work for #330882 (closed).

Screenshots or Screencasts (strongly suggested)

N/A

How to setup and validate locally (strongly suggested)

  1. Enable the vulnerability_finding_replace_metadata flag
    Feature.enable(:vulnerability_finding_replace_metadata)
  2. On the master branch, run a pipeline with a dependency scan twice (https://gitlab.com/gitlab-examples/security/security-reports)
  3. Go to a Dependency Scanning vulnerability. There should be 2 of each link.
  4. On this MR branch, run the pipeline again.
  5. Go back to the Dependency Scanning vulnerability. There should still only be 2 of each link.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Related to #330882 (closed)

Edited by Jonathan Schafer

Merge request reports