Skip to content

Add dedicated endpoints for project VSA

Ezekiel Kigbo requested to merge 335953-add-dedicated-project-vsa-endpoints into master

What does this MR do?

Introduces dedicated endpoints for fetching project value stream data, these endpoints were added in !66439 (merged) so we can now replace the existing project cycle analytics endpoints.

This MR:

  • Adds the new api requests for medians, records and stage counts to ~/api/analytics_api.js
  • Replaces the project VSA requests for records (stage events)
  • Replaces the project VSA stage median requests

Note: stage counts will be introduced in a follow-up MR

Screenshots or Screencasts (strongly suggested)

For verification, the data remains the same

Before After
Screen_Shot_2021-07-30_at_10.00.13_pm Screen_Shot_2021-07-30_at_10.19.21_pm
Screen_Shot_2021-07-30_at_10.00.29_pm Screen_Shot_2021-07-30_at_10.19.56_pm

How to setup and validate locally (strongly suggested)

  1. Seed VSA data for a project
$ VSA_SEED_PROJECT_ID=<project-id> VSA_ISSUE_COUNT=10 SEED_VSA=true FILTER=cycle_analytics rake db:seed_fu
  1. Visit value stream analytics for any project, for example http://gdk.test:3001/vsa-life/ror-project-vsa/-/value_stream_analytics
  2. The page should load with any available data, changing the date range or click on on a stage should refetch the data

Note: if the project does not belong to a group, you might need to apply this patch to run the seeding script, this should be fixed with !67222 (merged)

diff --git a/db/fixtures/development/17_cycle_analytics.rb b/db/fixtures/development/17_cycle_analytics.rb
index 826e703a443..a034c25f47a 100644
--- a/db/fixtures/development/17_cycle_analytics.rb
+++ b/db/fixtures/development/17_cycle_analytics.rb
@@ -149,7 +149,7 @@ def create_developers!
         email: "vsm-user-#{i}@#{suffix}.com"
       )
-      project.group.add_developer(user)
+      project.group.add_developer(user) if project&.group
       project.add_developer(user)
       @developers << user

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #335953 (closed)

Edited by Ezekiel Kigbo

Merge request reports

Loading