Use SSOT for checking if service ping is enabled via license or in application settings [RUN ALL RSPEC] [RUN AS-IF-FOSS]
requested to merge mwaw/337169-update-usage-ping-enabled-check-in-redis-ordinary-counters into master
What does this MR do?
It enabled Redis counters to track data even if only partial serivce ping reporting is enabled via license. Service Ping reporting is divided into two stages: tracking (recording metrics at instance level) and collection (reporting them to GitLab). This is MR is only about tracking stage. All permissions are checked again before collection.
Screenshots or Screencasts (strongly suggested)
How to setup and validate locally (strongly suggested)
- Either obtain license with customer service enabled or stub method response at
ee/modesl/license.rb
--- a/ee/app/models/license.rb
+++ b/ee/app/models/license.rb
@@ -577,6 +577,7 @@ def cloud_license?
def customer_service_enabled?
!!license&.operational_metrics?
+ true
end
def license_type-
Disable Service Ping
-
Check current state of
SearchCounterGitlab::UsageDataCounters::SearchCounter.read :all_searches -
Search any keyword in navbar
-
Check again current sstate of
SearchCounterGitlab::UsageDataCounters::SearchCounter.read :all_searches
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Related to #337169 (closed)
Edited by Mikołaj Wawrzyniak