Move scan policy logic to modal
What does this MR do?
The Scan Policies page under the Security & Compliance tab is being converted to Policies page where we will display a list of policies and add the ability to select the project to scan the policies from. As of today, this view only displays a dropdown and a button to save the policy project. With this commit, we move that logic inside a modal and add the ability to open the modal by clicking to a button.
There is no changelog for these changes because these changes are behind the :security_orchestration_policies_configuration
feature flag.
Screenshots or Screencasts (strongly suggested)
Before | After |
---|---|
Description | Screencast |
---|---|
Linking a new project | |
When user has no right to edit |
How to setup and validate locally (strongly suggested)
- Clone this project locally: https://gitlab.com/aturinske/sec-orchestration
- Set a dummy environment by visiting Deployments > Environments > New Environment
- Enable the
:security_orchestration_policies_configuration
feature flag - Click on Security & Compliance > Scan Policies
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #321884 (closed)