Skip to content

Move scan policy logic to modal

Savas Vedova requested to merge 321884-move-logic-to-modal into master

What does this MR do?

The Scan Policies page under the Security & Compliance tab is being converted to Policies page where we will display a list of policies and add the ability to select the project to scan the policies from. As of today, this view only displays a dropdown and a button to save the policy project. With this commit, we move that logic inside a modal and add the ability to open the modal by clicking to a button.

There is no changelog for these changes because these changes are behind the :security_orchestration_policies_configuration feature flag.

Screenshots or Screencasts (strongly suggested)

Before After
image image
Description Screencast
Linking a new project edit-policy
When user has no right to edit disabled-linking-project

How to setup and validate locally (strongly suggested)

  1. Clone this project locally: https://gitlab.com/aturinske/sec-orchestration
  2. Set a dummy environment by visiting Deployments > Environments > New Environment
  3. Enable the :security_orchestration_policies_configuration feature flag
  4. Click on Security & Compliance > Scan Policies

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #321884 (closed)

Edited by Savas Vedova

Merge request reports