Skip to content

Only allow validation when `allow_editing_commit_messages` is changed to true in `project_setting`

Subashis Chakraborty requested to merge fix-project-setting-validation into master

What does this MR do?

related to #328639 (closed)

There is a validation error happening ActiveRecord::RecordInvalid: Validation failed: Allow editing commit messages can't be enabled because signed commits are required for this project after the validation is introduced here. We discovered while we were discussion about this in TI refinement session, this validation is only required when allow_editing_commit_messages is enabled, otherwise we can skip this. If continue to do this for attribute update, this will throw an error like https://gitlab.com/gitlab-org/gitlab/-/blob/master/ee/app/services/security/store_reports_service.rb#L34

Does this MR meet the acceptance criteria?

Conformity

Edited by Subashis Chakraborty

Merge request reports