Update createStore to allow for multiple approval modules
What does this MR do?
This updates the createStore function to allow for multiple named approval modules.
This will be used in !66536 (merged) to allow the project approvals app to have both the approvals and approvalSettings modules needed for #335964 (closed).
Setup and testing
To test the group approval settings Vue application you need to:
- Have a GitLab Ultimate license.
- Enable the feature flag:
echo "Feature.enable(:group_merge_request_approval_settings)" | rails c - View the Merge request approvals at
[GDK_HOST]/groups/gitlab-org/-/editto confirm it's working. - Checkout
defaultbranch and confirm again.
Screenshots or Screencasts (strongly suggested)
No visual changes.
Group approval settings [GDK_HOST]/groups/gitlab-org/-/edit
| Before | After |
|---|---|
 |
 |
Project approvals [GDK_HOST]/gitlab-org/gitlab-shell/edit
| Before | After |
|---|---|
 |
 |
MR approvals [GDK_HOST]/gitlab-org/gitlab-shell/-/merge_requests/1/edit
| Before | After |
|---|---|
 |
 |
| All together |
|---|
 |
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) No visual change -
I have added/updated documentation, or it's not needed. (Is documentation required?) No visual change -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #335964 (closed)