Skip to content

Decode square brackets with "queryToObject" [RUN ALL RSPEC] [RUN AS-IF-FOSS]

What does this MR do?

Fix for #336895 (closed)

This change ensure that URL-encoded square brackets are decoded by "queryToObject" when such encoding is used in the URL.

Prevents edge cases in which clients send encoded square brackets to define arrays in their URL parameters.

Suggested MR view settings:

Screenshots or Screencasts (strongly suggested)

N/A

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #336895 (closed)

Edited by Miguel Rincon

Merge request reports