Skip to content

EE: 45560 provide zero configuration domain name for auto devops using nip io

See CE counterpart MR

What does this MR do?

  • Implements EE multi-cluster ingress default domains
    • Implements EE override for DeploymentPlatform#find_cluster
    • Moves AUTO_DEVOPS_DOMAIN to project#auto_devops_domain_variable, which is then used in CI::Build#persisted_environment_variables

This follows the following rules of precedence :

  1. cluster(s) IP based domain
  2. Auto DevOps domain or instance domain
  3. CI scoped variables (Settings > CI/CD > Variables, AUTO_DEVOPS_DOMAIN, with any environment scope)

NOTE : The move to deployment_variables basically means that AUTO_DEVOPS_DOMAIN variable will now only be available for the jobs that sets a environment in the gitlab-ci.yaml file.

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

Add support for multi-cluster scenario

Screenshots (if relevant)

Screen_Shot_2018-08-30_at_10.49.28_PM

Development tasks

  • Support multiple ingress default domains
    • add deployment_cluster to DeploymentPlatform
    • Move user provided value for AUTO_DEVOPS_DOMAIN from project#predefined_variables to project#deployment_variables
    • Set ingress default_domain for each environment in project#predefined_variables
  • [-] Help text for multiple clusters

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/45560

Edited by 🤖 GitLab Bot 🤖

Merge request reports

Loading