Skip to content

Update approvals store to be reusable

Jiaan Louw requested to merge 335964-refactor-approval-settings-app into master

What does this MR do?

Updates the group approvals store to make it a generic approvals store.

This makes it possible for the store to be reused for instance #325279 (closed) and project !66536 (merged) approval rules.

Setup & Testing

  1. You need a GitLab Ultimate license.
  2. You need to enable the feature flag: echo "Feature.enable(:group_merge_request_approval_settings)" | rails c
  3. View the Merge request approvals at [GDK_HOST]/groups/gitlab-org/-/edit to confirm it's working.
  4. Checkout default branch and confirm again.

Screenshots or Screencasts (strongly suggested)

Before After
image image

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #335964 (closed)

Merge request reports