Skip to content

Create GitLab branch from Jira issue: UI Polish

Tom Quirk requested to merge 2647-create-gitlab-branch-from-jira-issue-3 into master

What does this MR do?

this is behind feature flag jira_connect_create_branch, disabled by default.

This MR is the 4th part of #2647 (closed). In response to the UX review of !64890 (closed), a few changes have been made:

To achieve this, some minor re-organization of the frontend code has been done. We now have a pages directory which contains index.vue, and this renders our new branch form, and the success state.

To test

  1. Enable jira_connect_create_branch FF
  2. Navigate to http://gdk.test:3000/-/jira_connect/branches/new
  3. Try to create a branch
  4. Observe success state

Screenshots or Screencasts (strongly suggested)

Current state (video demo slightly outdated, the illustration has changed. See success state screenshot below):

new_branch_ui_polish

Success state

Screen_Shot_2021-07-29_at_7.01.57_pm

With no default branch name in URL query parameters

Screen_Shot_2021-07-27_at_4.48.26_pm

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Tom Quirk

Merge request reports