Skip to content

Fix: Maintainers should not be able to set the project compliance framework label

What does this MR do?

This MR fixes the permissions issue where maintainers could edit a projects compliance framework label.

This should not be possible as per our documentation and the original implementation issue.

This was erroneously changed when we removed the :ff_custom_compliance_frameworks feature flag.

Screenshots or Screencasts (strongly suggested)

As owner As maintainer
image image

Setup & testing

This requires a license of at least GitLab Premium

  1. Visit [HOST]/[GROUP]/[PROJECT]/edit#js-compliance-framework as a project owner
  2. Check that you can edit the selected compliance framework
  3. Visit the same page as a project maintainer
  4. Check that you are shown the selected compliance framework and cannot edit it

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #336591 (closed)

Edited by Robert Hunt

Merge request reports