Draft: [Do not merge] Test MR for pipeline changes on MR into stable branch
Test MR for !64903 (merged)
Verifies pipeline for MRs into stable branches.
Merge request reports
Activity
The
package-and-qa
job from pipeline https://gitlab.com/gitlab-org/gitlab/-/pipelines/340503530 triggered https://gitlab.com/gitlab-org/build/omnibus-gitlab-mirror/-/pipelines/340514642 downstream.The
Trigger:qa-test
job from pipeline https://gitlab.com/gitlab-org/build/omnibus-gitlab-mirror/-/pipelines/340514642 triggered https://gitlab.com/gitlab-org/gitlab-qa-mirror/-/pipelines/340549058 downstream.The
gitlab-qa
downstream pipeline failed! .
The
package-and-qa
job from pipeline https://gitlab.com/gitlab-org/gitlab/-/pipelines/340571028 triggered https://gitlab.com/gitlab-org/build/omnibus-gitlab-mirror/-/pipelines/340585065 downstream.The
Trigger:qa-test
job from pipeline https://gitlab.com/gitlab-org/build/omnibus-gitlab-mirror/-/pipelines/340585065 triggered https://gitlab.com/gitlab-org/gitlab-qa-mirror/-/pipelines/340631622 downstream.The
gitlab-qa
downstream pipeline failed! .
The
package-and-qa
job from pipeline https://gitlab.com/gitlab-org/gitlab/-/pipelines/340655673 triggered https://gitlab.com/gitlab-org/build/omnibus-gitlab-mirror/-/pipelines/340675290 downstream.The
Trigger:qa-test
job from pipeline https://gitlab.com/gitlab-org/build/omnibus-gitlab-mirror/-/pipelines/340675290 triggered https://gitlab.com/gitlab-org/gitlab-qa-mirror/-/pipelines/340721288 downstream.The
gitlab-qa
downstream pipeline failed! .
The
package-and-qa
job from pipeline https://gitlab.com/gitlab-org/gitlab/-/pipelines/340691453 triggered https://gitlab.com/gitlab-org/build/omnibus-gitlab-mirror/-/pipelines/340704698 downstream.The
Trigger:qa-test
job from pipeline https://gitlab.com/gitlab-org/build/omnibus-gitlab-mirror/-/pipelines/340704698 triggered https://gitlab.com/gitlab-org/gitlab-qa-mirror/-/pipelines/340743222 downstream.The
gitlab-qa
downstream pipeline failed! .Known unrelated failures: #333156 (closed), #336314 (closed) & #335227 (closed).
The
package-and-qa
job from pipeline https://gitlab.com/gitlab-org/gitlab/-/pipelines/340737163 triggered https://gitlab.com/gitlab-org/build/omnibus-gitlab-mirror/-/pipelines/340751512 downstream.The
Trigger:qa-test
job from pipeline https://gitlab.com/gitlab-org/build/omnibus-gitlab-mirror/-/pipelines/340751512 triggered https://gitlab.com/gitlab-org/gitlab-qa-mirror/-/pipelines/340783403 downstream.The
gitlab-qa
downstream pipeline failed! .
The
package-and-qa
job from pipeline https://gitlab.com/gitlab-org/gitlab/-/pipelines/340796710 triggered https://gitlab.com/gitlab-org/build/omnibus-gitlab-mirror/-/pipelines/340803268 downstream.The
Trigger:qa-test
job from pipeline https://gitlab.com/gitlab-org/build/omnibus-gitlab-mirror/-/pipelines/340803268 triggered https://gitlab.com/gitlab-org/gitlab-qa-mirror/-/pipelines/340833218 downstream.The
gitlab-qa
downstream pipeline failed! .
The
package-and-qa
job from pipeline https://gitlab.com/gitlab-org/gitlab/-/pipelines/340905280 triggered https://gitlab.com/gitlab-org/build/omnibus-gitlab-mirror/-/pipelines/340913024 downstream.The
Trigger:qa-test
job from pipeline https://gitlab.com/gitlab-org/build/omnibus-gitlab-mirror/-/pipelines/340913024 triggered https://gitlab.com/gitlab-org/gitlab-qa-mirror/-/pipelines/340928399 downstream.The
gitlab-qa
downstream pipeline failed! .
The
package-and-qa
job from pipeline https://gitlab.com/gitlab-org/gitlab/-/pipelines/340936670 triggered https://gitlab.com/gitlab-org/build/omnibus-gitlab-mirror/-/pipelines/340938298 downstream.The
Trigger:qa-test
job from pipeline https://gitlab.com/gitlab-org/build/omnibus-gitlab-mirror/-/pipelines/340938298 triggered https://gitlab.com/gitlab-org/gitlab-qa-mirror/-/pipelines/340951694 downstream.The
gitlab-qa
downstream pipeline failed! .
The
package-and-qa
job from pipeline https://gitlab.com/gitlab-org/gitlab/-/pipelines/340951261 triggered https://gitlab.com/gitlab-org/build/omnibus-gitlab-mirror/-/pipelines/340952870 downstream.The
Trigger:qa-test
job from pipeline https://gitlab.com/gitlab-org/build/omnibus-gitlab-mirror/-/pipelines/340952870 triggered https://gitlab.com/gitlab-org/gitlab-qa-mirror/-/pipelines/340967271 downstream.The
gitlab-qa
downstream pipeline failed! .
The
package-and-qa
job from pipeline https://gitlab.com/gitlab-org/gitlab/-/pipelines/340962262 triggered https://gitlab.com/gitlab-org/build/omnibus-gitlab-mirror/-/pipelines/340963787 downstream.The
Trigger:qa-test
job from pipeline https://gitlab.com/gitlab-org/build/omnibus-gitlab-mirror/-/pipelines/340963787 triggered https://gitlab.com/gitlab-org/gitlab-qa-mirror/-/pipelines/340978468 downstream.The
package-and-qa
job from pipeline https://gitlab.com/gitlab-org/gitlab/-/pipelines/340992493 triggered https://gitlab.com/gitlab-org/build/omnibus-gitlab-mirror/-/pipelines/340994842 downstream.The
gitlab-qa
downstream pipeline failed! .The
Trigger:qa-test
job from pipeline https://gitlab.com/gitlab-org/build/omnibus-gitlab-mirror/-/pipelines/340994842 triggered https://gitlab.com/gitlab-org/gitlab-qa-mirror/-/pipelines/341010821 downstream.The
gitlab-qa
downstream pipeline failed! .
assigned to @alberts-gitlab
- A deleted user
added Engineering Productivity backend documentation labels
1 Error CHANGELOG.md was edited. Please remove the additions and follow the changelog guidelines. If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
9 Warnings This merge request is definitely too big (20288 lines changed), please split it into multiple merge requests. This MR has a Changelog commit with the EE: true
trailer, but there are database changes which requires the Changelog commit to not have theEE: true
trailer. Consider removing theEE: true
trailer from your commits.This merge request changed files with disabled eslint rules. Please consider fixing them. This merge request contains deprecated components. Please consider using Pajamas components instead. For the following files, a review from the Data team and Product Intelligence team is recommended
Please check the product intelligence guide.ee/app/workers/geo/secondary_usage_data_cron_worker.rb
lib/gitlab/usage_data.rb
lib/gitlab/usage_data_non_sql_metrics.rb
lib/gitlab/usage_data_queries.rb
lib/gitlab/utils/usage_data.rb
spec/factories/usage_data.rb
spec/lib/gitlab/usage_data_metrics_spec.rb
spec/lib/gitlab/usage_data_non_sql_metrics_spec.rb
spec/lib/gitlab/usage_data_queries_spec.rb
spec/lib/gitlab/usage_data_spec.rb
spec/lib/gitlab/utils/usage_data_spec.rb
config/metrics/settings/20210702140138_collected_data_categories.yml
app/assets/javascripts/packages_and_registries/package_registry/components/details/app.vue
This merge request adds a new rule to app/assets/stylesheets/framework/common.scss or app/assets/stylesheets/utilities.scss. This merge request changed undocumented Vue components in
vue_shared/
. Please consider creating Stories for these components:app/assets/javascripts/vue_shared/components/filtered_search_bar/filtered_search_bar_root.vue
app/assets/javascripts/vue_shared/components/filtered_search_bar/tokens/weight_token.vue
app/assets/javascripts/vue_shared/components/project_selector/project_selector.vue
app/assets/javascripts/vue_shared/components/sidebar/labels_select_vue/dropdown_contents_labels_view.vue
app/assets/javascripts/vue_shared/components/sidebar/labels_select_vue/labels_select_root.vue
app/assets/javascripts/vue_shared/components/sidebar/labels_select_widget/labels_select_root.vue
This merge request does not refer to an existing milestone. Most of the time, merge requests should target master
. Otherwise, please set the relevantPick into X.Y
label.2 Messages This merge request adds or changes files that require a review from the Database team. This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge. This merge request requires a database review. To make sure these changes are reviewed, take the following steps:
- Ensure the merge request has database and databasereview pending labels. If the merge request modifies database files, Danger will do this for you.
- Prepare your MR for database review according to the docs.
- Assign and mention the database reviewer suggested by Reviewer Roulette.
The following files require a review from the Database team:
app/finders/groups_finder.rb
app/finders/security/jobs_finder.rb
db/migrate/20210708202548_add_scanners_column_to_approval_project_rules.rb
db/migrate/20210713123345_create_dast_profile_schedule.rb
db/migrate/20210713223941_remove_null_constraint_from_security_findings.rb
db/migrate/20210715074359_add_foreign_key_to_dast_profile_schedules_on_dast_profile.rb
db/migrate/20210715074933_add_foreign_key_to_dast_profile_schedules_on_user.rb
db/migrate/20210715075203_add_foreign_key_to_dast_profile_schedules_on_project.rb
db/migrate/20210720083432_change_application_setting_terms_not_null.rb
db/post_migrate/20210706142819_re_schedule_latest_pipeline_id_population.rb
db/post_migrate/20210713075117_re_schedule_latest_pipeline_id_population_with_logging.rb
db/schema_migrations/20210708202548
db/schema_migrations/20210713075117
db/schema_migrations/20210713123345
db/schema_migrations/20210713223941
db/schema_migrations/20210715074359
db/schema_migrations/20210715074933
db/schema_migrations/20210715075203
db/schema_migrations/20210720083432
db/structure.sql
ee/app/finders/ee/users_finder.rb
lib/gitlab/background_migration/backfill_snippet_repositories.rb
lib/gitlab/database/load_balancing/host.rb
lib/gitlab/database/metrics.rb
lib/gitlab/database/migrations/background_migration_helpers.rb
lib/gitlab/database/postgres_index.rb
lib/gitlab/database/reindexing.rb
lib/gitlab/database/reindexing/reindex_concurrently.rb
Documentation review
The following files require a review from a technical writer:
doc/administration/gitaly/configure_gitaly.md
doc/administration/gitaly/faq.md
doc/administration/gitaly/index.md
doc/administration/gitaly/praefect.md
doc/administration/monitoring/performance/grafana_configuration.md
doc/administration/operations/extra_sidekiq_processes.md
doc/administration/operations/extra_sidekiq_routing.md
doc/administration/polling.md
doc/administration/reference_architectures/3k_users.md
doc/administration/static_objects_external_storage.md
doc/api/graphql/reference/index.md
doc/api/index.md
doc/api/packages/helm.md
doc/api/projects.md
doc/api/releases/index.md
doc/api/settings.md
doc/ci/variables/predefined_variables.md
doc/ci/yaml/index.md
doc/development/background_migrations.md
doc/development/code_review.md
doc/development/documentation/styleguide/index.md
doc/development/documentation/styleguide/word_list.md
doc/development/ee_features.md
doc/development/pipelines.md
doc/development/service_ping/index.md
doc/development/service_ping/metrics_instrumentation.md
doc/development/service_ping/review_guidelines.md
doc/development/testing_guide/end_to_end/rspec_metadata_tests.md
doc/integration/datadog.md
doc/integration/index.md
doc/integration/jira/connect-app.md
doc/public_access/public_access.md
doc/subscriptions/quarterly_reconciliation.md
doc/subscriptions/self_managed/index.md
doc/update/img/batched_background_migrations_queued_v14_0.png
doc/update/index.md
doc/user/admin_area/analytics/dev_ops_report.md
doc/user/admin_area/approving_users.md
doc/user/admin_area/index.md
doc/user/admin_area/license.md
doc/user/admin_area/moderate_users.md
doc/user/admin_area/monitoring/background_migrations.md
doc/user/admin_area/settings/index.md
doc/user/admin_area/settings/sign_up_restrictions.md
doc/user/analytics/index.md
doc/user/group/devops_adoption/index.md
doc/user/group/value_stream_analytics/index.md
doc/user/packages/composer_repository/index.md
doc/user/packages/container_registry/index.md
doc/user/packages/helm_repository/index.md
doc/user/packages/maven_repository/index.md
doc/user/packages/nuget_repository/index.md
doc/user/profile/account/delete_account.md
doc/user/project/img/epics_swimlanes_v14_1.png
doc/user/project/img/issue_board_add_list_v14_1.png
doc/user/project/img/issue_board_assignee_lists_v14_1.png
doc/user/project/img/issue_board_milestone_lists_v14_1.png
doc/user/project/img/issue_boards_core_v14_1.png
doc/user/project/img/issue_boards_premium_v14_1.png
doc/user/project/issue_board.md
doc/user/project/merge_requests/code_quality.md
doc/user/project/repository/branches/default.md
doc/user/project/web_ide/index.md
doc/user/project/wiki/index.md
doc/user/upgrade_email_bypass.md
The review does not need to block merging this merge request. See the:
-
Metadata for the
*.md
files that you've changed. The first few lines of each*.md
file identify the stage and group most closely associated with your docs change. - The Technical Writer assigned for that stage and group.
- Documentation workflows for information on when to assign a merge request for review.
Disabled eslint rules
The following files have disabled
eslint
rules. Please consider fixing them:app/assets/javascripts/deprecated_jquery_dropdown/gl_dropdown.js
app/assets/javascripts/main.js
Run the following command for more details
node_modules/.bin/eslint --report-unused-disable-directives --no-inline-config \ 'app/assets/javascripts/deprecated_jquery_dropdown/gl_dropdown.js' \ 'app/assets/javascripts/main.js'
Deprecated components
These deprecated components are in the process of being migrated. Please consider using Pajamas components instead.
- .alert
Pipeline Changes
This merge request contains changes to the pipeline configuration for the GitLab project.
Please consider the effect of the changes in this merge request on the following:
- Effects on different pipeline types
- Effects on non-canonical projects:
gitlab-foss
security
dev
- personal forks
- Effects on pipeline performance
Please consider communicating these changes to the broader team following the communication guideline for pipeline changes
Changes to utility SCSS files
Addition to
app/assets/stylesheets/utilities.scss
You have added a new rule to
app/assets/stylesheets/utilities.scss
. Are you sure you need this rule?If it is a component class shared across items, could it be added to the component as a utility class or to the component's stylesheet? If not, consider adding it to
app/assets/stylesheets/framework/common.scss
If it is a new utility class, is there another class that shares the same values in either this file or in
app/assets/stylesheets/utilities.scss
? If not, please be sure this addition follows the Gitlab UI naming style so it may be removed when these rules are included. See Include gitlab-ui utility-class library for more about this project.Notification to the Data Team about changes to the db/structure.sql file, add label
Data Warehouse::Impact Check
.Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Valery Sizov ( @vsizov
) (UTC+2, 6 hours behind@alberts-gitlab
)David Sincheol Kim ( @dskim_gitlab
) (UTC+9.5, 1.5 hours ahead of@alberts-gitlab
)database Luis Mejia ( @lmejia2
) (UTC-6, 14 hours behind@alberts-gitlab
)Alex Ives ( @alexives
) (UTC-5, 13 hours behind@alberts-gitlab
)Engineering Productivity for CI, Danger Rémy Coutable ( @rymai
) (UTC+2, 6 hours behind@alberts-gitlab
)Rémy Coutable ( @rymai
) (UTC+2, 6 hours behind@alberts-gitlab
)frontend Peter Hegman ( @peterhegman
) (UTC-7, 15 hours behind@alberts-gitlab
)Nicolò Maria Mezzopera ( @nmezzopera
) (UTC+2, 6 hours behind@alberts-gitlab
)~migration No reviewer available No maintainer available product intelligence Piotr Skorupa ( @pskorupa
) (UTC+2, 6 hours behind@alberts-gitlab
)Maintainer review is optional for product intelligence QA Nick Westbury ( @nwestbury
) (UTC+1, 7 hours behind@alberts-gitlab
)Maintainer review is optional for QA test Quality for spec/features/*
Valery Sizov ( @vsizov
) (UTC+2, 6 hours behind@alberts-gitlab
)Maintainer review is optional for test Quality for spec/features/*
workhorse Steve Azzopardi ( @steveazz
) (UTC+2, 6 hours behind@alberts-gitlab
)Nick Thomas ( @nick.thomas
) (UTC+1, 7 hours behind@alberts-gitlab
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
Uncategorised files
These files couldn't be categorised, so Danger was unable to suggest a reviewer. Please consider creating a merge request to add support for them.
VERSION
config.ru
doc/.vale/gitlab/LatinTerms.yml
Sidekiq queue changes
This merge request contains changes to Sidekiq queues. Please follow the documentation on changing a queue's urgency.
These queues were added:
cronjob:app_sec_dast_profile_schedule
If needed, you can retry the
danger-review
job that generated this comment.You're about to release the feature with the feature flag. This process can only be done after the global rollout on production. Please make sure in the rollout issue that the preliminary steps have already been done. Otherwise, changing the YAML definition might not have the desired effect.
Generated by
Dangeradded 1 commit
- 1d23c7cb - Fixme: Removing ci-patterns from rule so we can test the change
- A deleted user
added databasereview pending label
- A deleted user
added product intelligence product intelligencereview pending labels
- A deleted user
added grouppipeline execution label
- A deleted user
added groupadoption [DEPRECATED] label and removed grouppipeline execution label
- A deleted user
added grouppipeline execution label and removed groupadoption [DEPRECATED] label
- A deleted user
added QA database feature flag frontend labels
The
package-and-qa
job from pipeline https://gitlab.com/gitlab-org/gitlab/-/pipelines/341035418 triggered https://gitlab.com/gitlab-org/build/omnibus-gitlab-mirror/-/pipelines/341039602 downstream.The
Trigger:qa-test
job from pipeline https://gitlab.com/gitlab-org/build/omnibus-gitlab-mirror/-/pipelines/341039602 triggered https://gitlab.com/gitlab-org/gitlab-qa-mirror/-/pipelines/341068690 downstream.The
gitlab-qa
downstream pipeline failed! .