Skip to content

Improve metric instrumentation generator [RUN ALL RSPEC] [RUN AS-IF-FOSS]

Alina Mihaila requested to merge am-improve-instrumentation-class-generator into master

What does this MR do?

  • Remove redis_hll type from the generator. We don't need a specific instrumentation class for Redis HLL metrics. We use the same class for all metrics RedisHLLMEtric.
  • Add operation option for database metric type.
  • Update templates according to implementation to use value{} and relation{} blocks

Screenshots or Screencasts (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Mikołaj Wawrzyniak

Merge request reports