Skip to content

Remove error description from invite group modal

What does this MR do?

Removes error field description from Invite a group modal.

  • Does not change the error field description always being displayed on the Invite Members modal, both with and without error message.

Resolves https://gitlab.com/gitlab-org/gitlab/-/issues/334524

Related to !56957 (comment 599556679)

  • Does not include a changelog entry because the invite modal is still behind the Feature flag :invite_members_group_modal

Related to feature flag rollout issue: https://gitlab.com/gitlab-org/gitlab/-/issues/247208

Screenshots or Screencasts (strongly suggested)

before after (no error) after (with error)
Screen_Shot_2021-07-21_at_10.28.23_AM Screen_Shot_2021-07-21_at_10.21.47_AM Screen_Shot_2021-08-04_at_8.25.18_PM
Screen_Shot_2021-07-21_at_10.21.53_AM Screen_Shot_2021-07-21_at_10.21.53_AM Screen_Shot_2021-07-21_at_10.22.19_AM

Testing

To enable the Invite modal:

  1. In a rails console: Feature.enable(:invite_members_group_modal)
  2. Visit Members page for project or group, as a user who can admin the group/project.
  3. Click the Invite a group button to launch the invite group modal.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #334524

Edited by Jackie Fraser

Merge request reports

Loading