Remove seat_link_enabled from ApplicationSettings db table
What does this MR do?
Part of https://gitlab.com/gitlab-org/gitlab/-/issues/332811
Prior to this change, the column seat_link_enabled
in ApplicationSettings
was ignored (!64160 (merged)) in the previous milestone. In the current milestone, the column can be dropped from the database.
Up migration:
== 20210721122840 RemoveSeatLinkEnabledFromApplicationSettings: migrating =====
-- remove_column(:application_settings, :seat_link_enabled)
-> 0.0148s
== 20210721122840 RemoveSeatLinkEnabledFromApplicationSettings: migrated (0.0237s)
Down migration:
== 20210721122840 RemoveSeatLinkEnabledFromApplicationSettings: reverting =====
-- add_column(:application_settings, :seat_link_enabled, :boolean, {:null=>false, :default=>true})
-> 0.0065s
== 20210721122840 RemoveSeatLinkEnabledFromApplicationSettings: reverted (0.0155s)
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) - [-] I have tested this MR in all supported browsers, or it's not needed.
- [-] I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Edited by Mayra Cabrera