Remove unused method InstanceSecurityDashboard#all_pipelines
What does this MR do?
This just removes an unused method InstanceSecurityDashboard#all_pipelines.
This method is doing a cross-join between ci_* and non ci_* tables
which will not be possible when we move ci_* tables to a separate
database (see &6289 (closed) ).
Based on a git grep all_pipelines and also
git grep InstanceSecurityDashboard I cannot seem to find any uses of
this method. In fact we also removed Namespace#all_pipelines a while
back too because it was unused
!62266 (merged) .
It appears this method was added in
!23232 (merged) but also
trying to search for usages of all_pipelines there I still cannot find
anything as it appears it may have just been replacing another method
that was unused. That other method seems to have been added in !21691 (merged) but then I found a comment in there which suggests this was only used in the included Vulnerable module !21691 (comment 263246091) . The include Vulnerable module appears to have been removed in !24757 (merged) so that is perhaps the point where we should have also removed this method.
Screenshots or Screencasts (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Closes #336557 (closed)