Prevent terms from being created if blank

Merged Max Woolf requested to merge 336452-fix-terms-deletion into master

What does this MR do?

Database Review


== 20210720083432 ChangeApplicationSettingTermsNotNull: migrating =============
-- execute("UPDATE application_setting_terms SET terms = '' WHERE terms IS NULL")
   -> 0.0051s
-- change_column_null(:application_setting_terms, :terms, false)
   -> 0.0018s
== 20210720083432 ChangeApplicationSettingTermsNotNull: migrated (0.0070s) ====


== 20210720083432 ChangeApplicationSettingTermsNotNull: reverting =============
-- change_column_null(:application_setting_terms, :terms, true)
   -> 0.0042s
== 20210720083432 ChangeApplicationSettingTermsNotNull: reverted (0.0043s) ====

Does this MR meet the acceptance criteria?


Availability and Testing


Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Related to #336452 (closed)

Edited by Mayra Cabrera

Merge request reports