Skip to content

Ignore full path matches when searching groups in REST API

Jan Provaznik requested to merge jp-descendant_search into master

What does this MR do?

When searching for groups, if parent parameter is used, it's more useful to ignore matches in the full path (as we are searching in a single group hierarchy), otherwise if the search string matches full path substring, we get not very useful list as basically all sub/descendant groups match.

In this MR we change REST API to delegate search param to finder (where it was added recently). Both /descendants and /subgroups endpoints are updated.

Related to #323307 (closed)

Screenshots or Screencasts (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Michael Kozono

Merge request reports