Move placement of "Compliance Framework" setting to Settings->General after Badges
requested to merge 324085-move-placement-of-compliance-framework-setting-to-settings-general-after-badges into master
What does this MR do?
This MR moves the compliance framework selector from the top of the general settings to a new Compliance framework section just after badges.
The underlying framework selection code hasn't changed, it is just being wrapped in an expandable section and the rspec tests have been updated.
Screenshots or Screencasts (strongly suggested)
Screencast
Screen_Recording_2021-07-20_at_09.48.42
Previous section
Before | After |
---|---|
![]() |
![]() |
New section
No frameworks with no permission to edit | No permission to edit | No frameworks with permission to edit | Editable |
---|---|---|---|
![]() |
![]() |
![]() |
![]() |
Does this MR meet the acceptance criteria?
Setup & testing
Note: This feature requires at least GitLab Premium
- Go to
[HOST]/[GROUP]/[PROJECT]/edit
and check the compliance framework is not in the top section but a new expandable one - As a group owner
- With no compliance frameworks, check the create text with link is shown
- With compliance frameworks, check that you can set a framework using the dropdown
- As a maintainer
- With no compliance frameworks, check the no frameworks text is shown
- With compliance frameworks, check that the disabled input is shown with the defined framework value
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Related to #324085 (closed)
Edited by Robert Hunt