Setup GitLab MailGun endpoint for syncing bounced invite emails - redo
!65078 (merged) as per https://gitlab.com/gitlab-org/gitlab/-/issues/333562#note_630076014
Re-implementation ofthe only difference is the add_column
has a conditional around it since some instances like .com
may already have the column from previous MR
Literally applied all the commits from the mentioned MR except database parts that have a conditional/file already existed since we didn't delete the migration file/schema file.
since !66327 (merged) and !66316 (merged) have been deployed to production and we are in %14.2, we can re-implement.
/cc @stanhu
What does this MR do?
- Implements Step 3 & most of 4 in this plan
- Adds mailgun endpoint to receive their permanent failure webhook
- Toggles mailgun functionality off of the
Gitlab::CurrentSettings.mailgun_events_enabled?
instead of.com
or not. - Removes development feature flag since most of the functionality(besides displaying the alerts) is ready through this MR and we can start collecting the data and state changes.
note
After this MR is merged and deployed to .com
we'll then need to do the enable mailgun
steps seen in this plan
Migration output
Migrate
❯ be rails db:migrate
== 20210719192928 AddInviteEmailSuccessToMember: migrating ====================
-- column_exists?(:members, :invite_email_success)
-> 0.0061s
-- add_column(:members, :invite_email_success, :boolean, {:null=>false, :default=>true})
-> 0.0076s
== 20210719192928 AddInviteEmailSuccessToMember: migrated (0.0138s) ===========
Rollback
❯ be rails db:migrate:down VERSION=20210719192928
== 20210719192928 AddInviteEmailSuccessToMember: reverting ====================
-- remove_column(:members, :invite_email_success)
-> 0.0046s
== 20210719192928 AddInviteEmailSuccessToMember: reverted (0.0047s) ===========
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #333562