Save visited URL filters to recent searches and update weight token list
What does this MR do?
This MR does two things
- Currently on the Haml issues page, visiting a URL with a search or filters saves them to the filtered search bar recent searches dropdown. This MR updates the Vue filtered search bar to have the same behaviour. This is tested in recent_searches_spec.rb#L40
- The Vue weight token was updated show a list of 21 values, to comply with the test dropdown_weight_spec.rb#L24
These two tests are currently passing because they test the Haml issues page. In !61123 (closed), these tests will test the new Vue issues page instead, so this MR ensures the expected behaviour for then.
The Vue issues page is behind the feature flag vue_issues_list
, defaulted to off.
Screenshots or Screencasts (strongly suggested)
Screen_Recording_2021-07-19_at_12.00.06_pm
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #322755 (closed)
Edited by Coung Ngo