Add more properties to the Secure scan snowplow tracking event
What does this MR do?
Adds the Analyzer ID (e.g. gitlab-dast
) as the event label
and the Scan type (e.g. dast/sast/etc
) as the event property
to the Snowplow event that is tracked whenever a Secure scan is executed.
While this data is already captured as part of the context, adding as label
and property
allows for filtering on these values in Sisense SQL queries as the context cannot be queried directly.
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Merge request reports
Activity
assigned to @cam_swords
added typefeature label
changed milestone to %14.1
- A deleted user
added backend label
1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Rubén Dávila ( @rdavila
) (UTC-5, 15 hours behind@cam_swords
)Imre Farkas ( @ifarkas
) (UTC+2, 8 hours behind@cam_swords
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger- Resolved by Nikola Milojevic
requested review from @rdavila
- Resolved by Cameron Swords
@alinamihaila could you please review this MR on behalf of product intelligence just to make sure I'm not abusing these properties?
requested review from @alinamihaila
added product intelligenceapproved label
removed review request for @alinamihaila
requested review from @nmilojevic1 and removed review request for @rdavila
changed milestone to %14.2
- Resolved by Nikola Milojevic
@nmilojevic1, thanks for approving this merge request.Please consider starting a new pipeline if:
- This is the first time the merge request is approved, or
- The merge request is ready to be merged, and there has not been a merge request pipeline in the last 2 hours.
For more info, refer to the guideline.
enabled an automatic merge when the pipeline for 3f8443f2 succeeds
mentioned in commit 6be45816
added workflowstaging label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
removed typefeature label