Skip to content
Snippets Groups Projects

Add linked pipelines to pipelines table

What does this MR do?

This MR adds linked pipelines (upstream/downstream) to the pipelines table component. This mimics the behavior used on the MR widget, which allows users to quickly navigate to an upstream or downstream pipeline. This change can be found when viewing the pipelines table or the pipelines tab on an MR (if your pipeline triggers another pipeline or has been triggered).

How to test (please test 😸)

Note: You need an active runner on your GDK that can pick up jobs.

Create a project named trigger-downstream or preference. Within that project have a .gitlab-ci.yml config. That project needs a job to trigger another pipeline in a project with a .gitlab-ci.yml config. This can be tested inverse with a project that gets triggered to create the upstream relationship.

The trigger job should look like

trigger_job:
  stage: test
  trigger: root/project_name

Related to: #36118 (closed)

Screenshots or Screencasts (strongly suggested)

LOCAL GDK

Pipelines Table

Screen_Shot_2021-07-21_at_11.06.07_AM

Pipelines Tab MR

Screen_Shot_2021-07-21_at_11.06.45_AM

Commit pipelines table

Screen_Shot_2021-07-21_at_11.07.09_AM

PRODUCTION CSS TEST IN BROWSER

These screenshots are to display no broken layout, does not include linked pipelines

Pipelines Table

Screen_Shot_2021-07-21_at_11.03.37_AM

Pipelines Tab MR

Screen_Shot_2021-07-21_at_11.04.34_AM

Commit pipelines table

Screen_Shot_2021-07-21_at_11.05.02_AM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #36118 (closed)

Edited by Payton Burdette

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Bundle size analysis [beta]

    This compares changes in bundle size for entry points between the commits dc6a267a and d3cb02d0

    Special assets

    Entrypoint / Name Size before Size after Diff Diff in percent
    mainChunk 1.87 MB 1.84 MB -28.57 KB -1.5 %
    average 3.09 MB 3.09 MB - -0.0 %

    😨 Significant Growth: 263

    Expand
    Entrypoint / Name Size before Size after Diff Diff in percent
    pages.admin.groups.show 131.98 KB 278.41 KB +146.43 KB 110.9 %
    pages.admin.projects 80.26 KB 226.58 KB +146.31 KB 182.3 %
    pages.import.bitbucket.status 241.23 KB 333.09 KB +91.86 KB 38.1 %
    pages.import.bitbucket_server.status 243.54 KB 335.4 KB +91.86 KB 37.7 %
    pages.import.fogbugz.status 230.23 KB 322.08 KB +91.86 KB 39.9 %
    pages.import.gitea.status 230.23 KB 322.08 KB +91.86 KB 39.9 %
    pages.import.github.status 230.23 KB 322.08 KB +91.86 KB 39.9 %
    pages.import.gitlab.status 230.23 KB 322.08 KB +91.86 KB 39.9 %
    pages.import.manifest.status 230.23 KB 322.08 KB +91.86 KB 39.9 %
    pages.admin.projects.index 162.85 KB 232.58 KB +69.73 KB 42.8 %

    The table above is limited to 10 entries. Please look at the full report for more details

    🆕 New entry points: 2

    Expand
    Entrypoint / Name Size before Size after Diff Diff in percent
    pages.admin.users.keys 0 Bytes 1.04 MB +1.04 MB 100.0 %
    pages.admin.licenses.show 0 Bytes 144.95 KB +144.95 KB 100.0 %

    🎉 Significant Reduction: 7

    Expand
    Entrypoint / Name Size before Size after Diff Diff in percent
    pages.admin.impersonation_tokens 1.06 MB 147.9 KB -933.25 KB -86.3 %
    pages.projects.boards 2.93 MB 2.82 MB -109.55 KB -3.7 %
    pages.groups.boards 2.91 MB 2.81 MB -100.57 KB -3.4 %
    pages.projects.cycle_analytics.show 423.45 KB 334.94 KB -88.5 KB -20.9 %
    pages.projects.security.vulnerability_report 2 MB 1.95 MB -50.68 KB -2.5 %
    pages.groups.security.vulnerabilities.index 1.88 MB 1.83 MB -46.88 KB -2.4 %
    pages.security.vulnerabilities.index 1.86 MB 1.81 MB -46.29 KB -2.4 %

    Your MR has at least one entrypoint growing significantly (more > 1 KB or 2%). If you write new or extend existing features, this is expected and there is nothing to worry about.

    Please consider pinging someone from the FE Foundations (@dmishunov, @justin_ho, @mikegreiling or @nmezzopera) for review, if you are unsure about the size increase.

    Note: We do not have exact data for dc6a267a. So we have used data from: 8f36e57e.
    The intended commit has no webpack pipeline, so we chose the last commit with one before it.

    Please look at the full report for more details


    Read more about how this report works.

    Generated by 🚫 Danger

  • Allure report

    allure-report-publisher generated test report for d3cb02d0!

    review-qa-smoke: 📝 test report

  • Payton Burdette marked the checklist item I have included changelog trailers, or none are needed. (Does this MR need a changelog?) as completed

    marked the checklist item I have included changelog trailers, or none are needed. (Does this MR need a changelog?) as completed

  • Payton Burdette marked the checklist item I have added/updated documentation, or it's not needed. (Is documentation required?) as completed

    marked the checklist item I have added/updated documentation, or it's not needed. (Is documentation required?) as completed

  • Payton Burdette marked the checklist item I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) as completed

    marked the checklist item I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) as completed

  • marked the checklist item I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) as completed

  • Payton Burdette marked the checklist item I have self-reviewed this MR per code review guidelines. as completed

    marked the checklist item I have self-reviewed this MR per code review guidelines. as completed

  • Payton Burdette marked the checklist item This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) as completed

    marked the checklist item This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) as completed

  • Payton Burdette marked the checklist item I have followed the style guides. as completed

    marked the checklist item I have followed the style guides. as completed

  • Payton Burdette marked the checklist item This change is backwards compatible across updates, or this does not apply. as completed

    marked the checklist item This change is backwards compatible across updates, or this does not apply. as completed

  • Payton Burdette marked the checklist item I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) as completed

    marked the checklist item I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) as completed

  • Payton Burdette marked the checklist item I have tested this MR in all supported browsers, or it's not needed. as completed

    marked the checklist item I have tested this MR in all supported browsers, or it's not needed. as completed

  • Payton Burdette marked the checklist item I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed. as completed

    marked the checklist item I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed. as completed

  • added 1 commit

    • 06a07f7c - Add linked pipelines to component

    Compare with previous version

  • Payton Burdette changed the description

    changed the description

  • Author Maintainer

    @jannik_lehmann would you mind doing the first review here?

    Edited by Payton Burdette
  • requested review from @jannik_lehmann

  • Jannik Lehmann requested review from @sarahghp and removed review request for @jannik_lehmann

    requested review from @sarahghp and removed review request for @jannik_lehmann

  • Jannik Lehmann approved this merge request

    approved this merge request

  • removed Deferred UX label

  • Removing UX debt as it does not meet the criteria.

  • removed review request for @sarahghp

  • added 1 commit

    • c3a28871 - Add linked pipelines to component

    Compare with previous version

  • added 1 commit

    • b440bbc6 - Add linked pipelines to component

    Compare with previous version

  • Payton Burdette changed the description

    changed the description

  • added 1 commit

    • 364abedd - Add linked pipelines to component

    Compare with previous version

  • Payton Burdette changed the description

    changed the description

  • added 1 commit

    • e221e755 - Add linked pipelines to component

    Compare with previous version

  • added 1 commit

    • d3cb02d0 - Add linked pipelines to component

    Compare with previous version

  • Payton Burdette requested review from @sarahghp

    requested review from @sarahghp

  • Payton Burdette changed the description

    changed the description

  • requested review from @nadia_sotnikova

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading