Skip to content

Fix background color of markdown code in dark mode

What does this MR do?

When using dark mode, the code highlight in markdown text (in comments) is not very visible as it is using the same background color as the light mode.

This MR sets a new background-color in app/assets/stylesheets/application_dark.scss that makes the highlight more visible for dark mode but remains unchanged for light mode.

Given that the description has a darker background color, the code highlight is already visible there but with this change it would be shown a little lighter.

Screenshots or Screencasts (strongly suggested)

Comments before Comments after
Screen_Shot_2021-07-15_at_12.15.24 Screen_Shot_2021-07-15_at_12.14.38
Screen_Shot_2021-07-15_at_12.05.15 Screen_Shot_2021-07-15_at_12.08.34
Light mode value before Light mode value after
Screen_Shot_2021-07-15_at_12.13.02 Screen_Shot_2021-07-15_at_12.11.53
Description before Description after
Screen_Shot_2021-07-15_at_18.10.39 Screen_Shot_2021-07-15_at_18.06.43l

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Eugenia Grieff

Merge request reports