Skip to content

Add detected_at to Vulnerabilities table

Michał Zając requested to merge 10272-add-detected-at-to-vulnerabilities into master

What does this MR do?

This MR adds detected_at column to vulnerabilities table.

When working on !61385 (merged) we realized there's no detected_at at column and created_at was used in it's place (which made sense since up until now vulnerabilities were created by scanners so created_at == detected_at).

Now that we want to create vulnerabilities via an API there can be cases where detected_at != created_at and we want to be able to reflect this.

In case detected_at is not provided it's assumed to be the same as created_at.

Migrations

❯ bundle exec rails db:migrate        
== 20210714120600 AddDetectedAtToVulnerabilities: migrating ===================
-- add_column(:vulnerabilities, :detected_at, :datetime_with_timezone)
   -> 0.0012s
-- change_column_default(:vulnerabilities, :detected_at, #<Proc:0x000056406def2258 /home/quintasan/sauce/gdk/gitlab/db/migrate/20210714120600_add_detected_at_to_vulnerabilities.rb:9 (lambda)>)
   -> 0.0045s
== 20210714120600 AddDetectedAtToVulnerabilities: migrated (0.0163s) ==========
❯ bundle exec rails db:rollback STEP=1                                
== 20210714120600 AddDetectedAtToVulnerabilities: reverting ===================
-- remove_column(:vulnerabilities, :detected_at)
   -> 0.0044s
== 20210714120600 AddDetectedAtToVulnerabilities: reverted (0.0045s) ==========

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Related to #10272 (closed)

Edited by Michał Zając

Merge request reports