Draft: Remove ajaxError.sentry event handler
What does this MR do?
Screenshots or Screencasts (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Merge request reports
Activity
- A deleted user
added frontend label
2 Warnings Please add a merge request type to this merge request. This merge request does not have any assignee yet. Setting an assignee clarifies who needs to take action on the merge request at any given time. 1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Ammar Alakkad ( @aalakkad
) (UTC+3, 1 hour ahead of@mrincon
)Savas Vedova ( @svedova
) (UTC+3, 1 hour ahead of@mrincon
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerBundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 7a99c1e7 and 61c4ed23
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.13 MB 3.13 MB - -0.0 % mainChunk 1.85 MB 1.85 MB - 0.0 %
Note: We do not have exact data for 7a99c1e7. So we have used data from: ca790b7b.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
Dangermentioned in issue #336057
Allure report
allure-report-publisher
generated test report for 61c4ed23!review-qa-smoke:
test reportchanged milestone to %14.2
Setting label grouprunner based on
@mrincon
's group.added grouprunner label
Setting label(s) Category:Runner devopsverify sectionops based on grouprunner.
added [Deprecated] Category:Runner devopsverify sectionops labels
changed milestone to %14.3
added missed:14.2 label
added 5647 commits
-
2441e01f...7a99c1e7 - 5646 commits from branch
master
- 61c4ed23 - Remove ajaxError.sentry event handler
-
2441e01f...7a99c1e7 - 5646 commits from branch
78 76 id: this.options.currentUserId, 79 77 }); 80 78 }, 81 82 bindSentryErrors() { 83 $(document).on('ajaxError.sentry', this.handleSentryErrors);