Skip to content
Snippets Groups Projects

Draft: Remove ajaxError.sentry event handler

Closed Miguel Rincon requested to merge mrincon-remove-ajaxError-sentry into master
1 unresolved thread

What does this MR do?

Screenshots or Screencasts (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Miguel Rincon

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
78 76 id: this.options.currentUserId,
79 77 });
80 78 },
81
82 bindSentryErrors() {
83 $(document).on('ajaxError.sentry', this.handleSentryErrors);
  • Author Maintainer

    I attempted to trigger ajax errors manually on my GDK and this handler was never run. I suspect this is not used.

    As we move away from jQuery.ajax it should still make sense to remove this, as even if it works it would not provide good coverage over global errors.

  • Please register or sign in to reply
  • Author Maintainer

    I am not actively working on this so I will close this MR.

    That said, I suspect there is some unused code in our Sentry configuration.

    cc @jivanvl @sarahghp

  • closed

  • Please register or sign in to reply
    Loading