Skip to content

Fix ::Ci::Minutes::UpdateBuildMinutesService called twice

Allison Browne requested to merge ab-fix-bad-merge into master

What does this MR do?

A change that was merged prior to a rename was not incorporated in the rename. !64934 (comment 625074734)

This would cause the email service to run twice and I'm not sure if that service is idempotent at the moment. So this could cause a bug where emails are sent twice if the service is not idempotent.

Screenshots or Screencasts (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Allison Browne

Merge request reports