Skip to content

Prevents autoclose for the shared projects filter

What does this MR do?

The shared analytics project filter dropdown can either be used for selecting a single project or set to multiselect, currently when multiselect is selected and a project is selected from the list, the dropdown closes and applies the selected project, this makes sense when only a single project can be selected, but is less ideal for selecting multiple projects at a time to apply filters to.

When mutliselect is set to true:

  • Prevents the project dropdown filter click events from bubbling
  • Emits the filter selected event when the user clicks outside the dropdown

Screenshots or Screencasts (strongly suggested)

Before After - fixed multiselect After - fixed scrolling
old-vsa-project-filter-update vsa-project-filter-update vsa-filter-scrolling

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #330314 (closed)

Edited by Martin Wortschack

Merge request reports