Update GraphQL project type field container_registry_enabled [RUN ALL RSPEC] [RUN AS-IF-FOSS]
What does this MR do?
Project#container_registry_enabled is being migrated to ProjectFeature#container_registry_access_level to allow the visibility of the Container Registry to be independent of the project visibility. Currently, if a user has access to a project, the user has access to the Container Registry as well. Once the migration is complete, admins will be able to set the visibility of the Container Registry to private even if the project is public. See #18792 (comment 624799727) for the current state of the migration.
This MR updates the container_registry_enabled field in GraphQL to return false if the container registry is enabled but the user does not have access to it.
Screenshots or Screencasts (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) - I have tested this MR in all supported browsers, or it's not needed.
- I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
- Label as security and @ mention
@gitlab-com/gl-security/appsec - The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- Security reports checked/validated by a reviewer from the AppSec team
Related to #18792 (closed)