[RUN ALL RSPEC] [RUN AS-IF-FOSS] Add license usage ping check to HLLRedisCounter
requested to merge 335674-track-events-with-redis-hll-if-usage-ping-enabled-or-if-license-usage-ping-is-enabled into master
What does this MR do?
Related to #335674 (closed).
This adds a Service Ping check License.current.customer_service_enabled? to decide whether to track the event or not for EE.
Including the check from ServicePing::PermitDataCategoriesService.product_intelligence_enabled? created issues with User.single_user queries being repeatedly executed in specs when event tracking was called and failing N+1 guard specs. The license check is an intermediary solution and a follow-up is needed to properly cache this check.
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Edited by Mikołaj Wawrzyniak