Fix GET requests from graphql client when using relative url
What does this MR do?
!65564 (merged) introduced a workaround for GET requests This MR fixes this workaround when used for instances with relative url
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Merge request reports
Activity
changed milestone to %14.1
assigned to @xanf
2 Warnings This merge request changed files with disabled eslint rules. Please consider fixing them. You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the tooling, ~"tooling::pipelines", ~"tooling::workflow", documentation, QA labels.Disabled eslint rules
The following files have disabled
eslint
rules. Please consider fixing them:app/assets/javascripts/lib/graphql.js
Run the following command for more details
node_modules/.bin/eslint --report-unused-disable-directives --no-inline-config \ 'app/assets/javascripts/lib/graphql.js'
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Zack Cuddy ( @zcuddy
) (UTC-5, 8 hours behind@xanf
)Olena HK. ( @ohoral
) (UTC+3, same timezone as@xanf
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerBundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 6d2f8e44 and 19ec2c8d
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.09 MB 3.09 MB - -0.0 % mainChunk 1.84 MB 1.84 MB - 0.0 %
Note: We do not have exact data for 6d2f8e44. So we have used data from: d6bb6a6c.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-review
job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerThe
package-and-qa
job from pipeline https://gitlab.com/gitlab-org/gitlab/-/pipelines/336028027 triggered https://gitlab.com/gitlab-org/build/omnibus-gitlab-mirror/-/pipelines/336057133 downstream.The
Trigger:qa-test
job from pipeline https://gitlab.com/gitlab-org/build/omnibus-gitlab-mirror/-/pipelines/336057133 triggered https://gitlab.com/gitlab-org/gitlab-qa-mirror/-/pipelines/336097896 downstream.The
gitlab-qa
downstream pipeline failed! .
- Resolved by Andrejs Cunskis
@acunskis as you originally discovered this issue could you please review and approve if it really fixes the problem :)
requested review from @acunskis
Allure report
allure-report-publisher
generated test report for 19ec2c8d!review-qa-smoke:
test report
package-and-qa: test reportadded Pick into auto-deploy priority1 severity1 labels
mentioned in issue #335884 (closed)
- Resolved by Sarah Groff Hennigh-Palermo
/cc @sarahghp for visibility
@vitallium could you please review this one-line fix in direct-to-maintainer mode?
assigned to @vitallium
mentioned in issue gitlab-org/quality/pipeline-triage#90 (closed)
mentioned in commit 7946d895
note: pressed merge by myself: previous merge by @vitallium failed with "try again"
Successfully picked into
14-1-auto-deploy-2021071311
. This merge request will receive additional notifications as it's deployed.removed Pick into auto-deploy label
mentioned in commit cf92079d
added workflowcanary label
added workflowproduction label and removed workflowcanary label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!39 (merged)