Respect absolute date user setting in MR widget
What does this MR do?
The MR Widget is not respecting the absolute date user setting because
it utilizes timeago.js
directly rather than our timeago utility
function. Adjusting it to use our utility fixes it.
Screenshots or Screencasts (strongly suggested)
Before | After |
---|---|
![]() |
![]() |
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Merge request reports
Activity
assigned to @leipert
changed milestone to %14.1
added frontend typemaintenance labels
added typefeature label
mentioned in issue #14560 (closed)
1 Warning You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the tooling, ~"tooling::pipelines", ~"tooling::workflow", documentation, QA labels.1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Florie Guibert ( @fguibert
) (UTC+10, 8 hours ahead of@leipert
)Jacques Erasmus ( @jerasmus
) (UTC+2, same timezone as@leipert
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger@jannik_lehmann Could you do the initial review?
requested review from @jannik_lehmann
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits a8407791 and 128be7d9
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.08 MB 3.08 MB - 0.0 % mainChunk 1.84 MB 1.84 MB - 0.0 %
Please look at the full report for more details
Read more about how this report works.
Generated by
DangerAllure report
allure-report-publisher
generated test report for 128be7d9!review-qa-smoke:
test report- Resolved by Jacques Erasmus
@leipert Changes look good to me! Since this includes userfacing-changes I think this should have a Changelog Footer in the Commit Message. WDYT?
Edited by Jannik Lehmann
requested review from @jerasmus
added groupecosystem [DEPRECATED] label
Setting label(s) devopscreate sectiondev based on ~"group::ecosystem".
added devopscreate sectiondev labels
mentioned in commit 983fe9da
added workflowstaging label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
added 1 deleted label and removed devopscreate label
removed typefeature label
added devopsmanage label and removed 1 deleted label