Create branch from Jira issue MVC 2: add new_branch_form Vue App
What does this MR do?
This MR is part 2/3 for #2647 (closed). For a full-context MR (all of these MRs combined), see !64890 (closed).
In this MR, we add a new component new_branch_form.vue, which uses the 2 new components introduced in !66034 (merged). We also add the boilerplate to mount the Vue app.
There are no user-facing changes in this MR, as the backend is not merged yet, thus there is no mount point for our Vue application!
UX will be reviewed in the full-context MR: !64890 (closed). Any required changes as a result of the UX review will be made in follow-up MRs.
| Iteration | MR |
|---|---|
| 1. frontend Add supporting Vue components | !66034 (merged) |
| 2. frontend Add the parent Vue app and initialization JS |
|
| 3. backend Add the backend | !66032 (merged) |
Screenshots or Screencasts (strongly suggested)
This video demo is from the full context MR !64890 (closed), so you can see the form in-action. To reiterate, there are no user-facing changes in this MR.
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #2647 (closed)