Skip to content

Draft: Remove name filter from ci pipelines finder

Thong Kuah requested to merge remove_name_filter_from_ci_pipelines_finder into master

What does this MR do?

Removes name filter from ci pipelines finder.

Ignores the name parameter in the pipelines v4 API because the finder does not support it anymore. Accordingly deprecates this field for removal in API v5.

GraphQL is un-changed because it does not have a name filter

Extracted from MR: !62092 (closed) Epic: &6167 (closed)

Action needed

This MR will require action from the team which owns this code. Please validate if this approach is appropriate (whether we can "break" API responses now or not), or update this MR with an alternative solution noting that we cannot join between ci_* tables and non ci_* tables.

Screenshots or Screencasts (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

#336953 (closed)

Edited by Dylan Griffith

Merge request reports