Draft: Global Search - Refactor Header Search
What does this MR do?
This change is WIP and not yet finished being implemented
Closes #297396 (closed)
This change is behind a feature flag (:new_header_search)
This change will most likely be broken down into smaller chunks depending on the size it ends up achieving.
This goal here is to replace the large deprecated jquery component used for the Header Search: https://gitlab.com/gitlab-org/gitlab/-/blob/master/app/assets/javascripts/search_autocomplete.js
Replacing it with GitLab UI will allow us to add features more effectively as well as true up the styles permanently by using the GitLab UI component.
There are quite a few features in this combo search/dropdown field that will need to be verified before we remove the Feature Flag.
Here is a full roadmap for when the missing features will be added: #297396 (comment 665578315)
Screenshots or Screencasts (strongly suggested)
Default Options (No Search)
| Collapsed | Expanded (No Search) | |
|---|---|---|
| Color Theme (Basic) |  |
 |
| Light Theme |  |
 |
| Dark Mode |  |
 |
Autocomplete Options (w/ Search)
| Dashboard | From Project |
|---|---|
 |
 |
How to test?
- Fetch and checkout this branch
- From your GDK terminal, access the rails console by typing
rails c - Enable the feature flag by typing
Feature.enable(:new_header_search) - Test the new Top Nav Search UI, checking that all existing functionality remains
- To disable the feature flag follow steps 2 and 3 but rather type
Feature.disable(:new_header_search)
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec - [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team