Skip to content

Fix escaped chars in remove and delete modals

Olena Horal-Koretska requested to merge 330725-do-not-escape-special-chars into master

What does this MR do?

Fixes escaped chars in remove and delete users modals Also, I've found the issue that userName was not provided to oncall-schedules-list component in delete user modal and fixed that as well.

To test go to Your project=>Members=>Try deleting a user Or got to admin part=>Users=>Try removing a user. Make sure that special chars are not escaped in confirmation modals in user names

Screenshots or Screencasts (strongly suggested)

header Before After
Remove Screenshot_2021-07-12_at_18.47.21 Screenshot_2021-07-12_at_18.47.59
Delete Screenshot_2021-07-12_at_18.46.41 Screenshot_2021-07-12_at_18.45.46

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #330725 (closed)

Edited by Olena Horal-Koretska

Merge request reports