Optimized blob view loading in repository
What does this MR do?
Optimizes the loading process for the textual blobs in the repository. This is especially important for the large blobs.
Briefly about what's going on here.
The mechanics here are trivial:
- We limit the number of lines we render on the screen to 70, no matter the blob size
- We render the remaining lines when the browser is idling
Does the line linking still work in this scenario?
Yes, it does
Screenshots or Screencasts (strongly suggested)
No visual changes in the blob rendering as all the lines visible to the user will be output at the same time in this MR.
The changes in the performance parameters:
Before (master) |
After (this MR) |
|---|---|
 |
 |
The runtime parameters for both tests:
- Local GDK
- Production Build
- Sitespeed: 17.8.0
- Chrome 91.0.4472.77
- 3 runs in both cases presenting the median
Most important changes:
With the same local env, the LCP dropped from 17.33s to 5.834s that give performance boost of about backEndTime (TTF essentially). Taking that into account gives even bigger difference between the tests
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #328220 (closed)