Skip to content

Only renders notes tab when viewing discussions

Phil Hughes requested to merge ph/notesOverviewRendering into master

What does this MR do?

This changes when we render the discussions on the merge request overview tab. Instead of always rendering the content, this changes it to only render the discussions whenever the user is on the overview tab. This helps save memory, especially on larger merge requests.

Locally I saw a smaller merge request drop ~10mb in memory.

Screenshots or Screencasts (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Merge request reports