Skip to content

WIP Adjust timeout thresholds for end to end search test results

Erick Banks requested to merge egb-adjust-search-wait-thresholds into master

What does this MR do?

I've adjusted the timeouts for end to end test search calls to 3 minutes (10 increments of 18 second waits) because according to our severity matrix https://about.gitlab.com/handbook/engineering/development/enablement/search/#severity-labels-for-search-issues-advanced-search-global-search any insert and recall procedure that takes less than 3 minutes is expected normal result.

I've also removed a retrier that wrapped the it clauses in qa/qa/specs/features/ee/browser_ui/enablement/elasticsearch/elasticsearch_reindexing_spec.rb because that test retries search availability three times inside the assert_elasticsearch_responding call in qa/qa/runtime/search.rb and I don't see a need to retry search twice.

Screenshots or Screencasts (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Erick Banks

Merge request reports

Loading