Fix rename table migration procedure
What does this MR do?
This change fixes a few issues with the rename table migration procedure. During #201856 (closed) we've identified that in some cases ActiveRecord
does not use the schema cache and it queries the schema directly.
This is a problem in a zero-downtime migration environment.
- Migrations are executed (not post migrations), the table is renamed, the view is in place.
- A node, using the old version of the application is restarted.
- The restarted node queries the schema directly and determines that there is no FK (on the view).
- Application errors can happen due to the missing primary key.
- Issue is fixed once the deployment finishes.
This MR ensures that all schema lookup related methods proxy the query to the correct database table.
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Adam Hegyi