Skip to content

Skip LFS fragment on redirect

Pascal Fautré requested to merge Scapal/gitlab:master into master

What does this MR do?

Fixes issue #335495 (closed) : LFS download service not skipping body fragment on redirect:

When mirroring an external repository using object storage (Gitlab + S3), I get a 'size mismatch' error.

This is due to the body of the redirection not being skipped in this code: https://gitlab.com/gitlab-org/gitlab/-/blob/master/app/services/projects/lfs_pointers/lfs_download_service.rb#L63

Does this MR meet the acceptance criteria?

Minor change only impacting LFS download service

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Robert May

Merge request reports

Loading