Skip to content

Reset job_token_scope_enabled setting to false

Fabio Pitino requested to merge reset-job-token-scope-enabled-2 into master

What does this MR do?

Related to #333002 (closed)

This MR is based on top of !64962 (merged) where we remove the default: true value at the model-level for this setting. Given that the feature flag hasn't been fully enabled for this feature we need to start with the setting to be false for all projects.

In a follow-up MR, after we enabled the feature flag by default we will also change the default value to true so that it will apply to all new projects.

Database migration

rails db:migrate:redo VERSION=20210628124505

== 20210628124505 ResetJobTokenScopeEnabled: reverting ========================
== 20210628124505 ResetJobTokenScopeEnabled: reverted (0.0000s) ===============

== 20210628124505 ResetJobTokenScopeEnabled: migrating ========================
-- remove_column(:project_ci_cd_settings, :job_token_scope_enabled)
   -> 0.0027s
-- add_column(:project_ci_cd_settings, :job_token_scope_enabled, :boolean, {:default=>false, :null=>false})
   -> 0.0044s
== 20210628124505 ResetJobTokenScopeEnabled: migrated (0.0200s) ===============

Screenshots or Screencasts (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Fabio Pitino

Merge request reports