Improve regex used in "require_migration!" test helper
What does this MR do?
I've noticed this while working on !64159 (merged).
Vim (and probably other editors) create hidden temp files for the files that are open for editing.
Example: If we open migration file like
20210615234935_fix_batched_migrations_old_format_job_arguments.rb
Vim will create file named
.20210615234935_fix_batched_migrations_old_format_job_arguments.rb.swp
When running the migrations test spec/migrations/fix_batched_migrations_old_format_job_arguments_spec.rb
, require_migration!
test helper will fail with
LoadError:
cannot load such file -- /Users/krasio/projects/gitlab/ee/gitlab/db/post_migrate/.20210615234935_fix_batched_migrations_old_format_job_arguments.rb.swp
# ./spec/support/helpers/require_migration.rb:25:in `require_migration!'
# ./spec/support/helpers/require_migration.rb:51:in `require_migration!'
# ./spec/migrations/fix_batched_migrations_old_format_job_arguments_spec.rb:4:in `<top (required)>'
because it pick up the swp
file, instead of the migration file.
This MR updates the helper to match only on the file's basename, and also updates the regex used to find the migration file, so that it does not match swp
files.
- The regex before - https://rubular.com/r/J1pTK1abHAJjxi.
- The regex after - https://rubular.com/r/NZhPDcbzBwtJYw.
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team