Skip to content

Prevent Transfering a Group with a Subscription

What does this MR do?

Prevents transferring a group with a subscription to another group.

It is currently possible to transfer a root group with a subscription to another group. The group becomes a subgroup with an associated subscription. This should not be possible; only root groups may have a subscription. This MR fixes the issue by preventing the transfer of any group with a subscription.

More details are available in the issue.

Issue: https://gitlab.com/gitlab-org/gitlab/-/issues/330524

Screenshots

Go to the group page, then go to Settings > General > Advanced. There you will see the Transfer group pane pictured below.

Before

This is how the Transfer group pane looks currently for all groups. It also still looks this way if the group does not have a subscription or for any subgroups.

Screen_Shot_2021-07-07_at_6.43.57_PM

After

This is how the Transfer group pane looks for a root group with a subscription after this MR.

Screen_Shot_2021-07-07_at_6.44.06_PM

If the parent group select dropdown is enabled via Chrome Devtools or the like, then the backend still denies the request and displays a flash message like the following.

Screen_Shot_2021-07-07_at_7.29.30_PM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Jason Goodman

Merge request reports