Skip to content

Add deprecated project filter component

Daniel Tian requested to merge 284471-old-project-filter into master

What does this MR do?

On the vulnerability report page, there is a collection of filter dropdowns:

ksnip_20210706-181759

Each dropdown is either a simple filter, or a variant that extends it. Because simple_filter.vue is used/extended for multiple filters, for flexibility the original implementation added the ability (through props) to show a search box and show a loading spinner. Since then though, it's become apparent that only the project filter needs to show a search box, and the loading prop is not used at all.

This MR refactors this by doing the following:

  1. The unused loading prop is removed from simple_filter.vue. Any filter that needs to use this prop will be a filter that extends simple_filter.vue.
  2. A new project_filter_old.vue component is created, and the code for showing the search box is moved into it from simple_filter.vue. It's called project_filter_old.vue because we have a newer project_filter.vue that's currently under testing, and will eventually replace project_filter_old.vue.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Edited by Daniel Tian

Merge request reports