Use row comparison in keyset pagination
What does this MR do?
This change uses row comparison in keyset pagination when the ORDER BY
columns are not nullable and the order direction is
the same.
Thanks, @pbair
for suggesting this technique!
Instead of building a complex UNION
query we can use: (created_at, id) > ('2012-09-18 01:40:01+00', 15)
- Old query example: https://explain.depesz.com/s/K2Kf
- New query example: https://explain.depesz.com/s/7W79
There is a tiny performance improvement when using the PG row comparison.
The change does not introduce new functionality, the following test cases are covering the change:
'./spec/lib/gitlab/pagination/keyset/order_spec.rb[1:1:2:1:2:1]' # Gitlab::Pagination::Keyset::Order paginate over items correctly when ordering by two non-nullable columns and a distinct column behaves like order examples when paginating forwards
'./spec/lib/gitlab/pagination/keyset/order_spec.rb[1:1:2:1:2:2:1]' # Gitlab::Pagination::Keyset::Order paginate over items correctly when ordering by two non-nullable columns and a distinct column behaves like order examples when paginating forwards with different page size
'./spec/lib/gitlab/pagination/keyset/order_spec.rb[1:1:2:1:3:1]'
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Alex Kalderimis