Skip to content

Improve new group form validations

Doug Stull requested to merge 17509-improve-new-group-form-validations into master

What does this MR do?

  • Adds the verbiage or spaces to the validation error on group url creation.
  • Adds limit of 255 to mirror the backend validation on the field - this mirrors how the description limit is handled and could be better than waiting for a backend validation?

Screenshots (strongly suggested)

A few of the areas where validation on name is applied...(try to create a group to trigger one)

Screen_Shot_2021-07-02_at_2.54.30_PM

Screen_Shot_2021-07-02_at_2.54.54_PM

Screen_Shot_2021-07-02_at_2.55.10_PM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #17509

Edited by Doug Stull

Merge request reports

Loading