Skip to content

Add limits to job logs

Marius Bobin requested to merge ci-add-job-trace-size-limit into master

What does this MR do?

Related to https://gitlab.com/gitlab-org/gitlab/-/issues/276192

It adds a limit of 100 megabytes to the job logs.

Script to generate a large trace:

image: ruby:alpine

test:
  script:
    - 'ruby -rsecurerandom -e "1000000000.times { |i| id = i.to_s.rjust(10, \"0\"); puts \"#{id}: #{SecureRandom.hex}\" }"'

Migration output

VERSION=20210702124842 bin/rails db:migrate:redo
== 20210702124842 AddCiJobTraceSizeToPlanLimits: reverting ====================
-- remove_column(:plan_limits, :ci_jobs_trace_size_limit, :integer, {:default=>100, :null=>false})
   -> 0.0092s
== 20210702124842 AddCiJobTraceSizeToPlanLimits: reverted (0.0115s) ===========

== 20210702124842 AddCiJobTraceSizeToPlanLimits: migrating ====================
-- add_column(:plan_limits, :ci_jobs_trace_size_limit, :integer, {:default=>100, :null=>false})
   -> 0.0055s
== 20210702124842 AddCiJobTraceSizeToPlanLimits: migrated (0.0056s) ===========

Screenshots (strongly suggested)

image

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Marius Bobin

Merge request reports