Update GitLab.com rate limit for authenticated API requests
What does this MR do?
This iterates on rate limiting which was enabled in the last year on GitLab.com.
This MR aligns our rate limits to what GitHub offers.
After discussion below, we have decided on a smaller iteration which will reduce the rate limit for authenticated api requests from 2k/min -> 1k/min.
Rate limits on the API is one of the best tools we have right now to avoid noisy-neighbor effects on Gitaly, that is causing disruption, and impacting our SLOs. Examples: gitlab-com/gl-infra/production#5037 (closed), https://gitlab.com/gitlab-com/gl-infra/production/-/issues/5031
If approved, we will first implement these limits in dry-run to see the affected users, we may need to add some whitelisting, or reach out to customers.
Rate limits
| Type | GitLab | GitHub | GitLab Proposed |
|---|---|---|---|
| API per user | 2000req/min | 5000req/hour | 1000req/min |
Rollout plan
-
Get approval for the rate limit change -
Run new rate limits in dry-run -
Merge and communicate update -
Apply rate limits
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team